[manila-csi-plugin] Remove rules from aggregated ClusterRoles to fix Helm v4 SSA conflict#3127
Conversation
…d SSA conflicts When a ClusterRole uses aggregationRule, the clusterrole-aggregation-controller owns the .rules field. Explicitly setting `rules: []` in the Helm template causes a field manager conflict with Helm v4's Server-Side Apply on upgrades. Omit the field entirely so ownership is not contested. Signed-off-by: Jathavedhan M <jathavedhan.m@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @carterpewpew. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
When a ClusterRole uses aggregationRule, the clusterrole-aggregation-controller takes SSA ownership of the .rules field. The chart currently renders rules: [] on both the controllerplugin and nodeplugin aggregated ClusterRoles. With Helm v4 (which defaults to Server-Side Apply), this causes a field manager conflict on every helm upgrade after the initial install, because both Helm and the aggregation controller claim ownership of .rules. This PR removes the redundant rules: [] from both templates. The aggregation controller continues to populate the rules from the matching child ClusterRoles as before.
Which issue this PR fixes(if applicable):
fixes #3119
Special notes for reviewers:
Release note: