[occm] Make hostNetwork configurable in the Helm chart#3097
[occm] Make hostNetwork configurable in the Helm chart#3097zwindler wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @zwindler. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dba59e8 to
bfcd6e6
Compare
What this PR does / why we need it:
Makes
hostNetworkconfigurable in the cloud controller manager Helm chart by adding ahostNetworkvalue (default:true).Currently
hostNetwork: trueis hardcoded in the DaemonSet template. This makes sense for the default use case where OCCM manages nodes and routes, but for users who only run a subset of controllers (e.g. just theservicecontroller for Octavia LB),hostNetworkis an unnecessary privilege escalation. The controller only needs to talk to the Kubernetes API and the OpenStack API, both reachable from pod networking.This PR also fixes
dnsPolicyto automatically useClusterFirstWithHostNetwhenhostNetworkistrue, as recommended by the Kubernetes docs:The current chart uses
dnsPolicy: ClusterFirstwithhostNetwork: true, which falls back to host DNS. This has no practical impact today since OCCM doesn't resolve cluster-internal service names, but it's technically incorrect.Which issue this PR fixes(if applicable):
N/A
Special notes for reviewers:
The default remains
hostNetwork: true, so this is a no-op for existing deployments.This PR contains two distinct changes: the
hostNetworktoggle and thednsPolicyfix. If you'd prefer to keep them separate, I can split this into two PRs.Release note: