[manila-csi-plugin, cinder-csi-plugin]: Allow cluster-id to be populated from configmap / secret

[1602077]

What this PR does / why we need it:

Adds supports for loading cluster_id from a secret / configmap in cluster. If clusterID is not set then CLUSTER_NAME can be overridden using extraEnv to pull configuration from an external object.

e.g.

# values.yaml
openstack-cinder-csi:
  clusterID: ""
  secret:
    filename: "cloud-config"
  csi:
    plugin:
      extraEnv:
        - name: CLUSTER_NAME
          valueFrom:
            configMapKeyRef:
              name: cluster-info
              key: cluster_uuid

This allows us to maintain a single configuration for manila / cinder for all of our cluster's, whilst ensuring that they correctly have the cluster-id metadata attached to the created shares / volumes for each cluster.

Which issue this PR fixes(if applicable):
fixes #3070

Special notes for reviewers:
None

Release note:

* [cinder-csi-plugin] Allow cluster-id to be populated from configmap / secret.
* [manila-csi-plugin] Allow cluster-id to be populated from configmap / secret.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: 1602077 / name: jack munday (225b7f7, 6370ce2, 857aca3)

[k8s-ci-robot]

Welcome @1602077!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @1602077. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kayrus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[1602077]

Hey - I've signed the CLA just now as this is my first PR into the kubernetes project. Please do let me know if there's anything else you need from me.

Cheers,
Jack

[gouthampacha]

/ok-to-test

[1602077]

hi @gouthampacha - please let me know if there is anything you need from me on this one before it can be reviewed.

cheers,
jack