Skip to content

Fix variable names in seed examples for offline mode#2061

Merged
kubermatic-bot merged 1 commit intokubermatic:mainfrom
bastianpaetzold:patch-1
Apr 15, 2026
Merged

Fix variable names in seed examples for offline mode#2061
kubermatic-bot merged 1 commit intokubermatic:mainfrom
bastianpaetzold:patch-1

Conversation

@bastianpaetzold
Copy link
Copy Markdown
Contributor

The "Offline Mode" documentation was refering to variable names with underscores in the seed configuration instead of their camel case version. I assume those are old name formats that were replaced at some point.

Additionally I removed the notion of hyperkube_image, which does not exist in the current CRD version, so I assume this is a legacy thing as well.

replaced variables with underscore with camel case version
removed hyperkube_image

Signed-off-by: Bastian Pätzold <37421217+bastianpaetzold@users.noreply.github.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2026
@kubermatic-bot
Copy link
Copy Markdown
Contributor

Hi @bastianpaetzold. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2026
@kubermatic-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2026
@csengerszabo
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@kubermatic-bot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 8d0e81dc02098a7dab88dc6c433cbdbbce20cbae

@kubermatic-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csengerszabo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@kubermatic-bot kubermatic-bot merged commit 70e3423 into kubermatic:main Apr 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants