Fix variable names in seed examples for offline mode#2061
Fix variable names in seed examples for offline mode#2061kubermatic-bot merged 1 commit intokubermatic:mainfrom
Conversation
replaced variables with underscore with camel case version removed hyperkube_image Signed-off-by: Bastian Pätzold <37421217+bastianpaetzold@users.noreply.github.com>
|
Hi @bastianpaetzold. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 8d0e81dc02098a7dab88dc6c433cbdbbce20cbae |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csengerszabo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The "Offline Mode" documentation was refering to variable names with underscores in the seed configuration instead of their camel case version. I assume those are old name formats that were replaced at some point.
Additionally I removed the notion of hyperkube_image, which does not exist in the current CRD version, so I assume this is a legacy thing as well.