Open
Conversation
assmass13
force-pushed
the
http-data-structures
branch
from
b4ca289 to
5a07d0f
Compare
OleksiyRudenko
requested changes
Oct 29, 2019
Member
OleksiyRudenko
left a comment
OleksiyRudenko
left a comment
There was a problem hiding this comment.
@assmass13 good job!
However your commit affects demo files added by @AMashoshyna :
- removes
submissions/amashoshyna/port-sniffer/index.js - removes
submissions/amashoshyna/port-sniffer/README.md
The above means these files will be no longer available for future contributors which is not really nice.
Please fix the issue.
assmass13
force-pushed
the
http-data-structures
branch
from
df43660 to
54cd56f
Compare
AMashoshyna
reviewed
Nov 11, 2019
Member
AMashoshyna
left a comment
AMashoshyna
left a comment
There was a problem hiding this comment.
With a small exception of await the code looks great! Please fix linting issues (they are all auto-fixable)
| }); | ||
| }); | ||
|
|
||
| const parseJson = async req => readBody(req).then(JSON.parse); |
Member
There was a problem hiding this comment.
async keyword is usually not needed when you don't use await.
| }; | ||
| } | ||
|
|
||
| async postStackRoute(req, res) { |
Member
There was a problem hiding this comment.
Same here: async keyword is redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Http server with data structures is developed