Refactor goroutines to improve readability#422
Refactor goroutines to improve readability#422arstanaly wants to merge 6 commits intokosli-dev:mainfrom
Conversation
aec1f61 to
72b4ee8
Compare
72b4ee8 to
37a4daf
Compare
|
Hey, @sami-alajrami 👋 |
Hey @arstanaly , thanks for the PR, the CI run is now approved |
CI is failing because env vars and secrets are not passed to the build from your branch and it does not seem Github gives an option to share those. Maybe the quickest way to progress on this for now is that I replicate your PR which you can then edit. |
I see, thanks for checking this. I will try to add unit tests with HTTP mocks for these to improve feedback loop. |
Refactor go routines in the CLI code to improve code readability and simplify error handling in the routines.