Skip to content

Conversation

@kosiew
Copy link
Owner

@kosiew kosiew commented Jul 8, 2025

Summary

  • handle deduplication for right/full joins by coalescing join keys
  • refactor join preparation to lower complexity
  • update tests to use supported sort API and full join keyword
  • fix lint issues

Testing

  • pre-commit run --files python/datafusion/dataframe.py python/tests/test_dataframe.py
  • uv run --no-project pytest python/tests/test_dataframe.py::test_join_invalid_params python/tests/test_dataframe.py::test_join_deduplicate python/tests/test_dataframe.py::test_join_deduplicate_multi python/tests/test_dataframe.py::test_join_deduplicate_select python/tests/test_dataframe.py::test_join_deduplicate_all_types -q

https://chatgpt.com/codex/tasks/task_e_686d059e74a48324965c15f22b22e9c4

@kosiew kosiew merged commit 10db8d6 into column-1173 Jul 8, 2025
0 of 2 checks passed
@kosiew kosiew deleted the codex/fix-join-deduplication-test-errors branch July 16, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants