Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Jan 21, 2026

  • instanced go functions as default
  • as instanced signature defaults to "OK" response, change this accordingly in tests (instead of echo response)
  • edit tests to now use instanced function instead of the static one
  • echo templates part of templates

@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2026
@gauron99 gauron99 changed the title Instanced go functions templates set as default [DNM][WIP]Instanced go functions templates set as default Jan 21, 2026
@gauron99 gauron99 changed the title [DNM][WIP]Instanced go functions templates set as default [DNM][WIP]Instanced go functions template default Jan 21, 2026
@gauron99 gauron99 force-pushed the instanced-funcs branch 2 times, most recently from f9d335e to 73387d9 Compare January 21, 2026 10:00
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.62%. Comparing base (94711b0) to head (d842983).

Files with missing lines Patch % Lines
pkg/deployer/testing/integration_test_helper.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (94711b0) and HEAD (d842983). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (94711b0) HEAD (d842983)
unit ubuntu-latest 1 0
e2e 3 0
unit macos-14 1 0
unit macos-latest 1 0
unit windows-latest 1 0
e2e springboot 1 0
e2e node 1 0
e2e python 1 0
e2e typescript 1 0
e2e go 1 0
e2e rust 1 0
integration 1 0
e2e quarkus 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3378       +/-   ##
===========================================
- Coverage   54.50%   43.62%   -10.89%     
===========================================
  Files         173      171        -2     
  Lines       19694    19686        -8     
===========================================
- Hits        10735     8588     -2147     
- Misses       7836    10313     +2477     
+ Partials     1123      785      -338     
Flag Coverage Δ
e2e ?
e2e go ?
e2e node ?
e2e python ?
e2e quarkus ?
e2e rust ?
e2e springboot ?
e2e typescript ?
integration ?
unit macos-14 ?
unit macos-latest ?
unit ubuntu-24.04-arm 43.62% <0.00%> (ø)
unit ubuntu-latest ?
unit windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the instanced-funcs branch 4 times, most recently from 3fbf389 to 4556925 Compare January 21, 2026 15:11
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2026
@gauron99 gauron99 changed the title [DNM][WIP]Instanced go functions template default [DNM][WIP] Update templates (instanced signature) Jan 21, 2026
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2026
@gauron99
Copy link
Contributor Author

/test all

@gauron99 gauron99 force-pushed the instanced-funcs branch 2 times, most recently from b3a6a98 to 9e8a5aa Compare January 22, 2026 18:08
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2026
@knative-prow knative-prow bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 23, 2026
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2026
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2026
@gauron99 gauron99 force-pushed the instanced-funcs branch 2 times, most recently from 9a72467 to d075366 Compare January 26, 2026 14:17
@knative-prow
Copy link

knative-prow bot commented Jan 26, 2026

@gauron99: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_func_main d842983 link true /test unit-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant