docs: prevent header tabs from overlapping on search expand#6556
docs: prevent header tabs from overlapping on search expand#6556jijo-OO7 wants to merge 4 commits intoknative:mainfrom
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jijo-OO7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jijo-OO7 I don't think you have actually followed the issue discussion, read it then open the PR. |
|
This is totally mis-aligned from what @dprotaso described there. |
|
Yeah I don't see any difference on Chrome Desktop. |
|
Note the idea is for the home, docs etc in the top row to not move when the search bar has focus |
|
Thanks for the pointer. I’ve re-read the original issue discussion and I see where the intent differs from the current implementation. |
|
Hi @dprotaso Updated the implementation based on your feedback. The top navigation now remains static when search gains focus by moving to a separate sticky container, following the Material for MkDocs pattern. Would appreciate your review to ensure this matches the intended behavior. Let me know if any further adjustments are needed. |
|
@jijo-OO7 I am not sure if this is what was described? the before version is not complete, initially there were elements in nav beside the search bar, which have been removed in after version, |
|
Final review to @dprotaso . Does not seem optimal to me. |
@jijo-OO7 Again, you did not follow the issue discussion, as Far as I know the nav elements were described to be overlayed by search bar expansion and not removed. |
|
@dprotaso Could you try reloading the preview? The navigation elements remain visible on my local build and the search expands as expected per the Material for MkDocs pattern. A cache refresh might resolve any discrepancies. |
|
I would expect |
|
Got it, thank you for clarifying. I understand now, the navigation items should remain aligned on the same horizontal line as the search bar. I'll revisit the implementation to ensure proper alignment and will push an updated commit shortly with Home, Docs, About, Blog, and Community properly aligned alongside the search bar. |
|
Do we expect the top nav to be static as well upon search expansion ? |
Yeah |
6b64dc1 to
cfe46da
Compare
|
Hi @dprotaso, I’ve updated the PR with the latest changes. Could you please take a look when you have a moment and let me know if this aligns with the intended vision, or if any further tweaks are needed? |
|
Fixed a broken redirect for the contributing docs that was causing the strict docs build to fail after rebasing onto the latest upstream/main |
3193b37 to
8826d64
Compare
|
@dprotaso I ran . I verified the current docs structure and we have docs/community/contributing.md (file), not docs/community/contributing/README.md (directory + file). I tried updating the redirect target to community/contributing.md, but the strict check still fails. This makes me think the CI check might be validating redirects against a different path layout (or across release branches where the structure differs). Could you confirm the expected redirect target here, or whether the strict check needs an update to reflect the current docs structure? |
You can ignore that check - it's not blocking the PR |
|
I fixed it in another PR (#6570) - but it didn't help the warning and I don't have time to dig into it |
|
FYI - I'm still seeing the same behaviour as before |
|
Thanks for flagging this I’ll take a closer look and dig into what might still be causing it. |
|
Note - I'm looking at the preview mentioned in this comment and still see the issue I'm going to mark this PR as a draft - until you see things working in the preview as expected then please switch it be ready |
0d62da1 to
ca6097b
Compare
|
I’ve pushed a follow-up that fixes the version selector overlap when the search bar is expanded. I’ve verified the latest preview on my end and it now behaves as expected. Could you please take another look and let me know if this works for us? I’m happy to make further tweaks if needed. |
|
I still see home, docs etc shifting around in the preview |


Header tabs overlap when search expands [Fixes #6332]
BEFORE
Proposed Changes
Reference: https://squidfunk.github.io/mkdocs-material/tutorials/
AFTER