Element Types in props were ignored #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we were looking to deprecate the elementTypes prop. Either use the is prop on the Input element or provide that in |
Contributor
Author
|
@bentatum Just for future reference: how do you plan to implement custom elementTypes then? Only by context? |
Collaborator
|
You can do it in context or directly on the is prop. And I think next version we want to move to a higher order component pattern. |
Collaborator
|
I would accept a PR removing elementTypes 😃 |
Collaborator
|
Thanks again for the contributions. We're both really busy, but we use this package quite a bit. It definitely needs more love. |
Contributor
Author
|
Okay, I will check that as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.