Feature/updater #272
Merged
Feature/updater #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Doesn't work if the OS does not allow deleting of the file while the timesheet generator is still running
- Tested on Windows 11 and MacOS Tahoe 26.1
Contributor
Author
|
is sonarqube broken? |
robinmaisch
requested changes
Dec 15, 2025
Member
robinmaisch
left a comment
robinmaisch
left a comment
There was a problem hiding this comment.
It's not easy to test the new feature, but it is looking good :)
If you can change this one thing, we are ready.
|
Contributor
Author
|
I have spent a good amount of time testing it on (mainly) macOS and Windows, everything should work, as long as the releases are always names v0.1.2 or just 0.1.2 |
robinmaisch
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updater
This pull request adds what I've been wanting to add for quite some time: Updating.
Now, when the TimesheetGenerator is started, it will compare the latest online version to the version listed in its pom.xml. If the online version is newer (not equal, obviously), the TimesheetGenerator will prompt the user if they wish to update. If they do, the process is like this:
3.1. Move the newly downloaded jar to where the old jar once was, copying the name and everything
3.2. Start the new TimesheetGenerator and close the current one via System.exit(0).
4.1. In this case, it gets a little bit more complicated: First, open the new temp jar file and tell it that it is an updater and the current real TimesheetGenerator filepath. After that, close.
4.2. The temp file will attempt to delete the file at the given path. If its not possible within 10 seconds, it times out and exits.
4.3. If successful, the temp file will copy itself to where the TimesheetGenerator was, launch that one, and kill itself.
4.4. The temp file will be deleted anyway through either starting the TimesheetGenerator immediately after, or the next time, so there is no need to worry about it.
Image of the prompt:
Additionally, all temporary jar files that follow the naming pattern are erased when starting the TimesheetGenerator UI.