Open
Conversation
- Only sample texture once instead of twice - Only 1 clip instruction - Remove empty alpha branched return (not needed afaik) - Use half floating point (mainly for mobile devices)
Author
|
@kirevdokimov Not sure if you saw this yet. I would appreciate it if you could take the time to look through it and if it is good merge it |
Owner
|
Hi @smitdylan2001, thank you for the PR! I am quite busy recently, but I will take a look and will let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested in editor and on Quest 3
btw, the default roundness value of 40 is so big on world space UI, that the image becomes invisible. Is it maybe an idea to change the default value in OnValidate or on Reset dependant on the world size of the image?