Add query parameter to events endpoint to filter on result #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the "data.result" query parameter can be added when calling the "/events" endpoint, add the "result" parameter for convenience. This will also shorten the entire query and hide some of the internal implementation details from the end-user, as in the future, the query parameters might be sanitised such that any unknown or unsupported values could be removed. Signed-off-by: Krzysztof Wilczyński <krzysztof.wilczynski@collabora.com>
nuclearcat
approved these changes
Apr 21, 2025
Member
nuclearcat
left a comment
nuclearcat
left a comment
There was a problem hiding this comment.
Thanks a lot Krzysztof, looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the
data.resultquery parameter can be added when calling the/eventsendpoint, add theresultparameter for convenience.This will also shorten the entire query and hide some of the internal implementation details from the end-user, as in the future, the query parameters might be sanitised such that any unknown or unsupported values could be removed.