live view telemetry#13
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR title 'live view telemetry' does not indicate changes to kernel API endpoints or Temporal workflows; please provide more details or opt in manually if this affects those areas. To monitor this PR anyway, reply with |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c787d1c. Configure here.

Note
Medium Risk
Adds a new built-in plugin that asynchronously sends session connect/disconnect events over HTTP, introducing new outbound network behavior and concurrency/queueing paths (though gated by a config flag and tested).
Overview
Adds a new built-in
telemetryplugin that can forward live-view session connect/disconnect events to a configured HTTP endpoint (defaulting tohttp://127.0.0.1:10001/telemetry/events), including a computedduration_mson disconnect.The plugin is opt-in via new flags
telemetry.enabledandtelemetry.endpoint, uses a bounded in-memory queue with a background worker (dropping events when saturated to avoid blocking session goroutines), and includes tests covering disabled behavior, event emission, and non-blocking behavior on endpoint failures.Reviewed by Cursor Bugbot for commit c787d1c. Bugbot is set up for automated code reviews on this repo. Configure here.