[kernel 1116] browser logging: cdp pipeline#194
Open
archandatta wants to merge 4 commits intomainfrom
Open
Conversation
archandatta
commented
Apr 2, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
archandatta
force-pushed
the
archand/kernel-1116/cdp-pipeline
branch
from
1e544a7 to
6d929c8
Compare
archandatta
force-pushed
the
archand/kernel-1116/cdp-pipeline
branch
from
6d929c8 to
76d837f
Compare
…ies and fix delimiter in CategoryFor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces new HTTP endpoints and lifecycle management for a CDP event capture pipeline; incorrect locking/start-stop behavior or incomplete
cdpmonitorimplementation could cause missed events or shutdown leaks.Overview
Adds a new events capture pipeline to the API server:
ApiServicenow owns anevents.CaptureSessionplus acdpmonitor.Monitor, wires them up inNew, and stops/closes them duringShutdown.Exposes new routes
POST /events/startandPOST /events/stopto (re)seed a fresh capture session ID and start/stop the CDP monitor under a mutex.Updates the
eventspackage to makeCaptureSessionrestartable viaStart(sessionID), switches timestamps to Unix milliseconds, makes sequence generation atomic, and addsevents.CategoryForto derive categories from type strings; tests are updated accordingly.Reviewed by Cursor Bugbot for commit 365787c. Bugbot is set up for automated code reviews on this repo. Configure here.