Skip to content

CLI: Update SDK to 91f2aa6572a40330669e39ec4d40cd0b1ee75812 and add new commands/flags #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kernel-internal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLI: Update SDK to 91f2aa6572a40330669e39ec4d40cd0b1ee75812 and add new commands/flags #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7716d9
CLI: Update SDK to 9e90177b921114c93e264ca9792537bf2d8de754 and add m…
kernel-internal[bot] Mar 30, 2026
26d22ee
CLI: Update SDK to 91f2aa6572a40330669e39ec4d40cd0b1ee75812 and add m…
kernel-internal[bot] Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions cmd/browser_pools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package cmd

import (
"context"
"encoding/json"
"fmt"
"strings"

Expand Down Expand Up @@ -86,6 +87,7 @@ type BrowserPoolsCreateInput struct {
ProfileName string
ProfileSaveChanges BoolFlag
ProxyID string
ChromePolicy string
Extensions []string
Viewport string
Output string
Expand Down Expand Up @@ -131,6 +133,14 @@ func (c BrowserPoolsCmd) Create(ctx context.Context, in BrowserPoolsCreateInput)
if in.ProxyID != "" {
params.ProxyID = kernel.String(in.ProxyID)
}
chromePolicy, err := parseChromePolicy(in.ChromePolicy)
if err != nil {
pterm.Error.Println(err.Error())
return nil
}
if len(chromePolicy) > 0 {
params.ChromePolicy = chromePolicy
}

params.Extensions = buildExtensionsParam(in.Extensions)

Expand Down Expand Up @@ -196,6 +206,7 @@ func (c BrowserPoolsCmd) Get(ctx context.Context, in BrowserPoolsGetInput) error
{"Kiosk Mode", fmt.Sprintf("%t", cfg.KioskMode)},
{"Profile", formatProfile(cfg.Profile)},
{"Proxy ID", util.OrDash(cfg.ProxyID)},
{"Chrome Policy", formatChromePolicy(cfg.ChromePolicy)},
{"Extensions", formatExtensions(cfg.Extensions)},
{"Viewport", formatViewport(cfg.Viewport)},
}
Expand All @@ -217,6 +228,7 @@ type BrowserPoolsUpdateInput struct {
ProfileName string
ProfileSaveChanges BoolFlag
ProxyID string
ChromePolicy string
Extensions []string
Viewport string
DiscardAllIdle BoolFlag
Expand Down Expand Up @@ -267,6 +279,14 @@ func (c BrowserPoolsCmd) Update(ctx context.Context, in BrowserPoolsUpdateInput)
if in.ProxyID != "" {
params.ProxyID = kernel.String(in.ProxyID)
}
chromePolicy, err := parseChromePolicy(in.ChromePolicy)
if err != nil {
pterm.Error.Println(err.Error())
return nil
}
if len(chromePolicy) > 0 {
params.ChromePolicy = chromePolicy
}

params.Extensions = buildExtensionsParam(in.Extensions)

Expand Down Expand Up @@ -472,6 +492,7 @@ func init() {
browserPoolsCreateCmd.Flags().String("profile-name", "", "Profile name")
browserPoolsCreateCmd.Flags().Bool("save-changes", false, "Save changes to profile")
browserPoolsCreateCmd.Flags().String("proxy-id", "", "Proxy ID")
browserPoolsCreateCmd.Flags().String("chrome-policy", "", "JSON object of Chrome enterprise policy overrides to apply to all browsers in the pool")
browserPoolsCreateCmd.Flags().StringSlice("extension", []string{}, "Extension IDs or names")
browserPoolsCreateCmd.Flags().String("viewport", "", "Viewport size (e.g. 1280x800)")

Expand All @@ -488,6 +509,7 @@ func init() {
browserPoolsUpdateCmd.Flags().String("profile-name", "", "Profile name")
browserPoolsUpdateCmd.Flags().Bool("save-changes", false, "Save changes to profile")
browserPoolsUpdateCmd.Flags().String("proxy-id", "", "Proxy ID")
browserPoolsUpdateCmd.Flags().String("chrome-policy", "", "JSON object of Chrome enterprise policy overrides to apply to all browsers in the pool")
browserPoolsUpdateCmd.Flags().StringSlice("extension", []string{}, "Extension IDs or names")
browserPoolsUpdateCmd.Flags().String("viewport", "", "Viewport size (e.g. 1280x800)")
browserPoolsUpdateCmd.Flags().Bool("discard-all-idle", false, "Discard all idle browsers")
Expand Down Expand Up @@ -539,6 +561,7 @@ func runBrowserPoolsCreate(cmd *cobra.Command, args []string) error {
profileName, _ := cmd.Flags().GetString("profile-name")
saveChanges, _ := cmd.Flags().GetBool("save-changes")
proxyID, _ := cmd.Flags().GetString("proxy-id")
chromePolicy, _ := cmd.Flags().GetString("chrome-policy")
extensions, _ := cmd.Flags().GetStringSlice("extension")
viewport, _ := cmd.Flags().GetString("viewport")
output, _ := cmd.Flags().GetString("output")
Expand All @@ -555,6 +578,7 @@ func runBrowserPoolsCreate(cmd *cobra.Command, args []string) error {
ProfileName: profileName,
ProfileSaveChanges: BoolFlag{Set: cmd.Flags().Changed("save-changes"), Value: saveChanges},
ProxyID: proxyID,
ChromePolicy: chromePolicy,
Extensions: extensions,
Viewport: viewport,
Output: output,
Expand Down Expand Up @@ -585,6 +609,7 @@ func runBrowserPoolsUpdate(cmd *cobra.Command, args []string) error {
profileName, _ := cmd.Flags().GetString("profile-name")
saveChanges, _ := cmd.Flags().GetBool("save-changes")
proxyID, _ := cmd.Flags().GetString("proxy-id")
chromePolicy, _ := cmd.Flags().GetString("chrome-policy")
extensions, _ := cmd.Flags().GetStringSlice("extension")
viewport, _ := cmd.Flags().GetString("viewport")
discardIdle, _ := cmd.Flags().GetBool("discard-all-idle")
Expand All @@ -603,6 +628,7 @@ func runBrowserPoolsUpdate(cmd *cobra.Command, args []string) error {
ProfileName: profileName,
ProfileSaveChanges: BoolFlag{Set: cmd.Flags().Changed("save-changes"), Value: saveChanges},
ProxyID: proxyID,
ChromePolicy: chromePolicy,
Extensions: extensions,
Viewport: viewport,
DiscardAllIdle: BoolFlag{Set: cmd.Flags().Changed("discard-all-idle"), Value: discardIdle},
Expand Down Expand Up @@ -687,6 +713,23 @@ func buildExtensionsParam(extensions []string) []kernel.BrowserExtensionParam {
return result
}

func parseChromePolicy(raw string) (map[string]any, error) {
raw = strings.TrimSpace(raw)
if raw == "" {
return nil, nil
}

var policy map[string]any
if err := json.Unmarshal([]byte(raw), &policy); err != nil {
return nil, fmt.Errorf("invalid --chrome-policy JSON: %w", err)
}
if policy == nil {
return nil, fmt.Errorf("--chrome-policy must be a JSON object")
}

return policy, nil
}

func buildViewportParam(viewport string) (*kernel.BrowserViewportParam, error) {
if viewport == "" {
return nil, nil
Expand Down Expand Up @@ -735,6 +778,19 @@ func formatExtensions(extensions []kernel.BrowserExtension) string {
return util.JoinOrDash(names...)
}

func formatChromePolicy(policy map[string]any) string {
if len(policy) == 0 {
return "-"
}

data, err := json.Marshal(policy)
if err != nil {
return fmt.Sprintf("%v", policy)
}

return string(data)
}

func formatViewport(viewport kernel.BrowserViewport) string {
if viewport.Width == 0 || viewport.Height == 0 {
return "-"
Expand Down
72 changes: 72 additions & 0 deletions cmd/browser_pools_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package cmd

import (
"context"
"testing"

"github.com/kernel/kernel-go-sdk"
"github.com/kernel/kernel-go-sdk/option"
"github.com/stretchr/testify/assert"
)

type fakeBrowserPoolsService struct {
newFunc func(ctx context.Context, body kernel.BrowserPoolNewParams, opts ...option.RequestOption) (*kernel.BrowserPool, error)
}

func (f *fakeBrowserPoolsService) List(ctx context.Context, opts ...option.RequestOption) (*[]kernel.BrowserPool, error) {
return &[]kernel.BrowserPool{}, nil
}

func (f *fakeBrowserPoolsService) New(ctx context.Context, body kernel.BrowserPoolNewParams, opts ...option.RequestOption) (*kernel.BrowserPool, error) {
if f.newFunc != nil {
return f.newFunc(ctx, body, opts...)
}
return &kernel.BrowserPool{}, nil
}

func (f *fakeBrowserPoolsService) Get(ctx context.Context, id string, opts ...option.RequestOption) (*kernel.BrowserPool, error) {
return &kernel.BrowserPool{}, nil
}

func (f *fakeBrowserPoolsService) Update(ctx context.Context, id string, body kernel.BrowserPoolUpdateParams, opts ...option.RequestOption) (*kernel.BrowserPool, error) {
return &kernel.BrowserPool{}, nil
}

func (f *fakeBrowserPoolsService) Delete(ctx context.Context, id string, body kernel.BrowserPoolDeleteParams, opts ...option.RequestOption) error {
return nil
}

func (f *fakeBrowserPoolsService) Acquire(ctx context.Context, id string, body kernel.BrowserPoolAcquireParams, opts ...option.RequestOption) (*kernel.BrowserPoolAcquireResponse, error) {
return &kernel.BrowserPoolAcquireResponse{}, nil
}

func (f *fakeBrowserPoolsService) Release(ctx context.Context, id string, body kernel.BrowserPoolReleaseParams, opts ...option.RequestOption) error {
return nil
}

func (f *fakeBrowserPoolsService) Flush(ctx context.Context, id string, opts ...option.RequestOption) error {
return nil
}

func TestBrowserPoolsCreate_MapsChromePolicy(t *testing.T) {
setupStdoutCapture(t)

fake := &fakeBrowserPoolsService{
newFunc: func(ctx context.Context, body kernel.BrowserPoolNewParams, opts ...option.RequestOption) (*kernel.BrowserPool, error) {
assert.Equal(t, map[string]any{
"HomepageLocation": "https://example.com",
"ShowHomeButton": true,
}, body.ChromePolicy)
return &kernel.BrowserPool{ID: "pool_123", Name: "test-pool"}, nil
},
}

cmd := BrowserPoolsCmd{client: fake}
err := cmd.Create(context.Background(), BrowserPoolsCreateInput{
Name: "test-pool",
Size: 1,
ChromePolicy: `{"HomepageLocation":"https://example.com","ShowHomeButton":true}`,
})

assert.NoError(t, err)
}
Loading
Loading