CLI: Update SDK to v0.30.0 and add new flags #102
Conversation
- Updated kernel-go-sdk from v0.28.0 to v0.29.0 - Added 1280x800@60 to available viewport configurations to match SDK update - Updated viewport test to reflect the new viewport option SDK release notes: - Add support for 1280x800@60 viewport - Add convenient param.SetJSON helper
- Update kernel-go-sdk from v0.29.0 to v0.30.0 - Add --status flag for browser list (active, deleted, all) - Add --async-timeout flag for invoke command SDK bump triggered by: kernel/kernel-go-sdk@6ca29d2
rgarcia
changed the title
|
🔧 CI Fix Available I've pushed a fix for the CI failure. The test |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "1920x1080@25", | ||
| "1920x1200@25", | ||
| "1440x900@25", | ||
| "1280x800@60", |
There was a problem hiding this comment.
Duplicate viewport entry in available viewports list
Medium Severity
The viewport "1280x800@60" was added at line 127, but it already exists at line 130 in getAvailableViewports(), creating a duplicate entry. This results in 8 items in the list while the test at line 1149 expects 7 items (assert.Len(t, viewports, 7)), causing a test failure. The new viewport should replace the existing one or not be added since it already exists.
Additional Locations (1)
| } | ||
| if asyncTimeout > 0 { | ||
| params.AsyncTimeoutSeconds = kernel.Opt(asyncTimeout) | ||
| } |
There was a problem hiding this comment.
Missing validation for async-timeout documented bounds
Low Severity
The --async-timeout flag help text states "(min 10, max 3600)" but the code only checks if asyncTimeout > 0 before passing the value to AsyncTimeoutSeconds. This allows values like 5 (below minimum) or 10000 (above maximum) to be sent to the API. Users relying on the documented constraints would expect invalid values to be rejected by the CLI with a helpful error.
This PR updates the Go SDK to 6ca29d21e5610db982caf74297cf481996793170 and adds CLI flags for new SDK parameters.
SDK Update
Coverage Analysis
A full enumeration of SDK methods and CLI commands was performed to identify coverage gaps.
New Flags
--statusforkernel browsers list- Filter by status: 'active' (default), 'deleted', or 'all'. Corresponds toBrowserListParams.Status--async-timeoutforkernel invoke- Timeout in seconds for async invocations (min 10, max 3600). Corresponds toInvocationNewParams.AsyncTimeoutSecondsDeprecations
--include-deletedforkernel browsers listas deprecated in favor of--statusTriggered by: kernel/kernel-go-sdk@6ca29d2
Reviewer: @stainless-app[bot]
Note
Medium Risk
Moderate risk due to SDK upgrade and changed request parameters/flag semantics for
browsers listandinvoke, which could alter CLI behavior against the API if mappings or defaults are incorrect.Overview
Updates
kernel-go-sdktov0.30.0and aligns CLI commands with new API capabilities.kernel browsers listnow supports a new--statusfilter (active/deleted/all), deprecates--include-deleted, and conditionally shows theDeleted Atcolumn based on the chosen status.kernel invokeadds an--async-timeoutflag that setsAsyncTimeoutSecondson invocation creation, and browser viewport options/tests are updated to include1280x800@60.Written by Cursor Bugbot for commit 440c557. This will update automatically on new commits. Configure here.