Skip to content

added unittest for octokit module #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sekhar-Kumar-Dash wants to merge 14 commits into from
Closed

added unittest for octokit module #64

Sekhar-Kumar-Dash wants to merge 14 commits into from

Conversation

@Sekhar-Kumar-Dash
Copy link
Contributor

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash commented Mar 13, 2023

Related Issue
Info about Issue or bug
Closes: keploy/keploy#354

Describe the changes you've made
Added a unit test for integrations/octokit module's wrappedNodeFetch function using typescript sdk.

@Sekhar-Kumar-Dash
added unitest1.ts
9525d86 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash Sekhar-Kumar-Dash mentioned this pull request Mar 13, 2023
Closed
12 tasks
@Sonichigo
Copy link
Contributor

Sonichigo commented Mar 13, 2023

Can @re-Tick please review the PR ?

@re-Tick
Copy link
Contributor

re-Tick commented Mar 15, 2023

Hi @Sekhar-Kumar-Dash, Please add a job in .github action to run the test files and give code coverage

@Sekhar-Kumar-Dash
updated package.json
7c3b2fe 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
updated ci.yml
16a4c94 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 16, 2023 •
edited
Loading

Hi @Sekhar-Kumar-Dash, Please add a job in .github action to run the test files and give code coverage

@re-Tick i updated the files please check

@Sekhar-Kumar-Dash
modified package.json
feb0011 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
re-Tick
re-Tick reviewed Mar 19, 2023
View reviewed changes
re-Tick
re-Tick reviewed Mar 19, 2023
View reviewed changes
@Sekhar-Kumar-Dash
updated ci.yml
b436325 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
updated unittest.ts
55cf7e6 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 19, 2023

@re-Tick updated the files please check it

@re-Tick
Copy link
Contributor

re-Tick commented Mar 20, 2023 •
edited
Loading

There should be some more testcases in unit test for test, off mode. And please resolve the errors in the cli.

Sekhar-Kumar-Dash and others added 8 commits March 23, 2023 20:33
@Sekhar-Kumar-Dash
updated package.json
406332c 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
modified yarn.lock
da0666c 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
added package-lock.json
f448362 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
added package-lock.json
e07f898 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
added package.json
ccf27fd 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
modified yarn.lock
3cdda69 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
modified unittest1.ts
d8f329a 
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
Update yarn.lock
9033bca
@Sekhar-Kumar-Dash Sekhar-Kumar-Dash deleted the master branch March 24, 2023 15:10
@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 24, 2023

There should be some more testcases in unit test for test, off mode. And please resolve the errors in the cli.

please review the new pr had to delete the last one because vscode updated somefiles on its own which cause merge conflicts
i have added some more test cases and resolved all the cli please check it here
#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@re-Tick re-Tick re-Tick left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[test]: add unit tests for octokit module

3 participants

@Sekhar-Kumar-Dash @Sonichigo @re-Tick