Open
Conversation
Contributor
Author
|
What do you think of this one ? |
yegor-babiy
reviewed
Aug 7, 2019
| ); | ||
| } | ||
|
|
||
| destinationItems = selectedItems.filter( |
Contributor
There was a problem hiding this comment.
Did you find case when destinationItems is not empty? becouse I can't find use case for it, I think it's redundancy
Contributor
Author
There was a problem hiding this comment.
No, I haven't. Since it was some legacy code, I was frightened to remove it.
yegor-babiy
reviewed
Aug 7, 2019
| if (keepSelectionOrder) { | ||
| // In order to keep selection order on the list, | ||
| // First, iterate threw already selectedItems | ||
| alreadySelectedItems = selectedItems.filter(item => findItem(item, items)); |
Contributor
There was a problem hiding this comment.
- alreadySelectedItems is the same that contains in selectedItems, I think doesn't make seanse to do such filtering
- your fix doesn't work when I use selection with Shift
Contributor
I am ok, but we need to be sure that we will cover all use cases, |
baptwaels
force-pushed
the
feat-add-keep-selection-order-props
branch
from
c50759b to
678755e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Proposed Changes