feat: Invoke-FuzzyEdit - UNC Path Support#201
Open
mattcargile wants to merge 1 commit intokelleyma49:masterfrom
Open
feat: Invoke-FuzzyEdit - UNC Path Support#201mattcargile wants to merge 1 commit intokelleyma49:masterfrom
Invoke-FuzzyEdit - UNC Path Support#201mattcargile wants to merge 1 commit intokelleyma49:masterfrom
Conversation
Add logic if `pwd` is a UNC path. Starting a `cmd.exe` process from a UNC path displays an unecessary warning message so ensuring the `pwd` is set to `$HOME`. `Get-FileSystemCmd` - Add logic for `cmd.exe` UNC handling requiring pushd into the UNC path for searching. `Get-EditorLaunch` - Use `ProviderPath` property for Resolve-Path instead of default `ToString()` output. `(resolve-path '\\localhost\c$\users\').ToString()` returns `Microsoft.PowerShell.Core\FileSystem::\\localhost\c$\users\` which isn't supported by native terminal or visual text editors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
Add logic if
pwdis a UNC path. Starting acmd.exeprocess from a UNC path displays an unecessary warning message so ensuring thepwdis set to$HOME.Get-FileSystemCmd- Add logic forcmd.exeUNC handling requiringpushdinto the UNC path for searching.Get-EditorLaunch- UseProviderPathproperty forResolve-Pathinstead of defaultToString()output.(resolve-path '\\localhost\c$\users\').ToString()returnsMicrosoft.PowerShell.Core\FileSystem::\\localhost\c$\users\which isn't supported by native terminal or visual text editors.