Skip to content

chore: change var to secret on workflow #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaryWylde merged 1 commit into from
Apr 27, 2026
Merged

chore: change var to secret on workflow #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/playwright-scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ jobs:
# Suggested setup:
# If the environment needs auth headers or cookies to reach the app,
# add those as repo secrets and wire them through `env:` here.
PLAYWRIGHT_STAGING_URL: ${{ vars.PLAYWRIGHT_STAGING_URL }}
PLAYWRIGHT_PRODUCTION_URL: ${{ vars.PLAYWRIGHT_PRODUCTION_URL }}
PLAYWRIGHT_STAGING_URL: ${{ secrets.PLAYWRIGHT_STAGING_URL }}
PLAYWRIGHT_PRODUCTION_URL: ${{ secrets.PLAYWRIGHT_PRODUCTION_URL }}
# Disable the webServer block in playwright.config.ts — in CI we run
# against a deployed URL, never against a freshly-spawned `yarn dev`.
PLAYWRIGHT_NO_SERVER: '1'
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
URL="$PLAYWRIGHT_STAGING_URL"
fi
if [ -z "$URL" ]; then
echo "::error ::Base URL for environment '$ENV_INPUT' is not configured. Set the PLAYWRIGHT_${ENV_INPUT^^}_URL repository variable."
echo "::error ::Base URL for environment '$ENV_INPUT' is not configured. Set the PLAYWRIGHT_${ENV_INPUT^^}_URL repository secret."
exit 1
fi
echo "base_url=$URL" >> "$GITHUB_OUTPUT"
Expand Down
Loading