Do not translate backup filename TIME placeholder format #12742
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format string should be written using the tokens derived from English, i.e. "yyyy" for years. The example leads one to believe that tokens derived from the user's current language could be used. Fix Finnish and Ukrainian because those are the two that I could spot that make this error.
ilkka
force-pushed
the
dont-translate-format-string-tokens
branch
from
6a9c14c to
afb7be6
Compare
Member
|
Translations are fixed on Transifex. This is something that should be done there or the source translation needs to be updated to contain a placeholder that is an untranslatable string. Personally, I wouldn't mind localising the pattern, as not everyone is able to read English date formats. Though I do see that this might cause problems if the language uses a different alphabet. |
Author
|
Okay, it's just that these example patterns just don't work. |
Member
|
Dealing with localized pattern matching is a nightmare, no thanks. I made the changes in transifex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format string should be written using the tokens derived from English, i.e. "yyyy" for years. The example leads one to believe that tokens derived from the user's current language could be used. Fix Finnish and Ukrainian because those are the two that I could spot that make this error.
Screenshots
Testing strategy
Type of change