Skip to content

Comments

Suggested Changes/Edits#227

Open
thumpersecure wants to merge 19 commits intokaifcodec:mainfrom
thumpersecure:main
Open

Suggested Changes/Edits#227
thumpersecure wants to merge 19 commits intokaifcodec:mainfrom
thumpersecure:main

Conversation

@thumpersecure
Copy link
Contributor

(changes)

Fixed CLI bug in main.py:
category-not-found message used args.module incorrectly; now uses args.category.

Improved randomness safety in core/helpers.py:
switched random.choice(...) -> secrets.choice(...) for proxy/user-agent selection.

Hardened version handling in core/version.py:
narrowed broad exception handling and removed noisy print(e) fallback in PyPI version fetch.

Improved updater robustness in utils/update.py:
fixed Fore.reset bug (Fore.RESET is correct),
narrowed exception handling (PackageNotFoundError, OSError), added safe Bandit suppressions for fixed-arg subprocess calls.

Added regression test in tests/test_helpers.py:
test_category_not_found_reports_category_name. Clean up Bandit nosec annotations

Cleaned annotation format so Bandit parses cleanly (no parser warnings).

cursoragent and others added 7 commits February 20, 2026 21:47
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
…ons with pattern syntax

- Add user_scanner/core/patterns.py with [chars]{lens} parser
- Replace -p/--permute and generate_permutations with inline pattern expansion
- Support [a-z], [0-9], {1-2}, {1;2}, escaping (\[ \] \\)
- Add -r/--random for random expansion order
- Add 15 pattern tests in tests/test_patterns.py
- Update README, FLAGS.md, and PR_184_INTEGRATION.md for upstream contribution

Co-authored-by: thumpersecure <thumpersecure@pm.me>
@kaifcodec
Copy link
Owner

@thumpersecure I’ve reviewed the changes, the code improvements and bug fixes look solid, and the --random flag addition is a nice addition.

However, this PR also includes changes from #184, which is still open. Because of that, we can’t merge this PR in its current state.

Create a new branch from main and push only the independent code improvement, bug fixing commits there (also don't close this PR):

Make sure that branch does not include any changes related to #184. Then open a separate PR with just those updates.

This will allow us to merge the improvements independently while keeping #184 isolated.

cursoragent and others added 12 commits February 22, 2026 01:44
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Remove patterns feature, PR_184_INTEGRATION.md, and all cursor/code-quality
changes that were not part of the upstream repository. This brings the fork
back in sync with kaifcodec/user-scanner:main.

https://claude.ai/code/session_01M8p4Co7GcSc1dsUcpuYFVR
Revert PR kaifcodec#184 changes and sync with upstream main
Claude/review pr 227 h m94 y
* Fix permutation coverage and remove silent error swallowing



* Apply targeted enhancements to CLI, helpers, and updater



* Clean up Bandit nosec annotations in updater



* feat: Integrate PR kaifcodec#184 Patterns feature - replace permutations with pattern syntax

- Add user_scanner/core/patterns.py with [chars]{lens} parser
- Replace -p/--permute and generate_permutations with inline pattern expansion
- Support [a-z], [0-9], {1-2}, {1;2}, escaping (\[ \] \\)
- Add -r/--random for random expansion order
- Add 15 pattern tests in tests/test_patterns.py
- Update README, FLAGS.md, and PR_184_INTEGRATION.md for upstream contribution



* Revert PR kaifcodec#184 changes and sync with upstream main

Remove patterns feature, PR_184_INTEGRATION.md, and all cursor/code-quality
changes that were not part of the upstream repository. This brings the fork
back in sync with kaifcodec/user-scanner:main.

https://claude.ai/code/session_01M8p4Co7GcSc1dsUcpuYFVR

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Co-authored-by: thumpersecure <thumpersecure@pm.me>
Fix permutation coverage and remove silent error swallowing
kaifcodec pushed a commit that referenced this pull request Feb 23, 2026
json-hunter07 added a commit that referenced this pull request Feb 23, 2026
fix: apply targeted enhancements from PR #227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants