Cyclomatic complexity: globalize fetch dependency helper #621
+83
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a dependency helper replacing repetative parts of code - update template to use it
eshulman2
changed the title
eshulman2
changed the title
mandre
reviewed
Jan 2, 2026
Collaborator
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Thanks, this is great! Would it also be possible to update existing controllers to use this new FetchDependency() function? This would help visualize the changes made to the template.
| Description: string(ptr.Deref(filter.Description, "")), | ||
| {{- range .ImportDependencies }} | ||
| {{ . }}: ptr.Deref({{ . | camelCase }}.Status.ID, ""), | ||
| {{ . }}ID: {{ . | camelCase }}ID, |
Collaborator
There was a problem hiding this comment.
Was this a bug in the original template? I'm unclean why this is changed while ImportDependencies remains identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid cyclomatic complexity issue I added a global dependency helper that reduces code duplication and complexity across the code (similar to the one I added to the server controller). Now it should be easier to manage dependencies and the code duplication should be (somewhat reduced).