fix: swap runtime disposal ordering in asyncify variant#256
Open
hectorm wants to merge 1 commit intojustjake:mainfrom
Open
fix: swap runtime disposal ordering in asyncify variant#256hectorm wants to merge 1 commit intojustjake:mainfrom
hectorm wants to merge 1 commit intojustjake:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While upgrading to 0.32.0 I ran into this error when host functions (created via
newFunction()) were still referenced at teardown:After digging into it, the cause is that
module-asyncify.tscallsdeleteRuntime()beforeQTS_FreeRuntime(), so by the time GC runs thehost_ref_finalizerfor HostRef objects, the runtime's callbacks are already gone from the map.I just copied into
module-asyncify.tsthe same changes made tomodule.tsin #227 (reference).