Parse misuse resistance #191
Conversation
…municate to later stages
The following code can easily be mistaken for using the context to
store information retrieved by render_to_lines. This is actually not
the case.
let mut context = self.make_context();
self.do_parse(&mut context, input)
.render_with_context(&mut context, 100, self.decorator);
sftse
force-pushed
the
parse-misuse-resistance
branch
from
2c3a1c2 to
de29b06
Compare
|
Hi, |
Note that it does not hold that HtmlContext::default() == config::plain().make_context() but the relevant fields used by fn parse_with_context() are the same. This is a bit unclear, so this change makes this more transparent.
sftse
force-pushed
the
parse-misuse-resistance
branch
2 times, most recently
from
a78b581 to
0ec601f
Compare
|
If #192 gets accepted, we'll rebase on main. What remains is the last commit, which originally suggested to replace On second thought, we're not so sure anymore we'll want to configure |
…method on Config The parse function is an odd one in the current API, other functions can be separated cleanly into functions that are convenient and functions that need to be configured. The parse function does not advertise what configuration it uses, and will silently drop css information, as it parses with config::plain() as default configuration. This can lead to the following misuse of the public API let render_tree = parse(html)?; customcfg.render_to_string(render_tree, 80)?;
sftse
force-pushed
the
parse-misuse-resistance
branch
2 times, most recently
from
1b9fc9c to
fbaf8b3
Compare
2 participants
The parse function is potentially easy to misuse.
Also, some unrelated refactors.