Add sidebar navigation to introduction page #870
Merged
javiert-okta merged 12 commits intomasterfrom Aug 8, 2025
Merged
Conversation
Contributor
|
There seems to be some issues with the first sections:
Maybe it could be fixed by using different values for threshold and rootMargin in the IntersectionObserver. 🤔 Screen.Recording.2025-08-06.at.12.59.17.PM.mov |
Contributor
Author
|
Looks like we can move around the value for rootMargin to fix that. Thanks @christiansamaniego-okta ! |
christiansamaniego-okta
previously approved these changes
Aug 8, 2025
Contributor
christiansamaniego-okta
left a comment
There was a problem hiding this comment.
Thank you for addressing the previous issue @javiert-okta. Looks awesome!
Nit pick: A couple very minor things I'll leave as optional:
- Make the divider match the color of the divider at the top of the page (below the "Introduction to JSON Web Tokens" heading)
- Adding some margin at the bottom so that the divider doesn't touch the component at the bottom
Contributor
Author
|
Nice suggestions @christiansamaniego-okta. I addressed both of them, take a look. |
christiansamaniego-okta
approved these changes
Aug 8, 2025
Contributor
christiansamaniego-okta
left a comment
There was a problem hiding this comment.
LGTM! Good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sidebar navigation to the introduction page with the following features:
https://next-jwt-8ftcynofz-okta-3f38a12f.vercel.app/introduction#how-json-web-tokens-work