Merged
Conversation
| const dictionary = JSON.parse(source) as LibraryDictionaryModel; | ||
| const allOptions = Object.keys(Object.values(dictionary)[0].libs[0].support); | ||
| const indexAlgorithmStart = allOptions.findIndex( | ||
| (option) => option == "hs256" |
Contributor
There was a problem hiding this comment.
Suggested change
| (option) => option == "hs256" | |
| (option) => option === "hs256" |
Contributor
|
Hello Javi. Looks great! just one thing. The "All" programming language filter doesn't work as expected. It doesn't display any libraries. Maybe we're considering the "all" query parameter as a programming language? We should add a check for that. |
christiansamaniego-okta
approved these changes
Jul 30, 2025
Contributor
christiansamaniego-okta
left a comment
christiansamaniego-okta
left a comment
There was a problem hiding this comment.
Looks good! Thank you Javi. One future improvement could be splitting the filters into different dropdowns. Let me know what you think.
Contributor
Author
|
Sounds a good improvement for the future, I'll create a ticket to address it and discuss with the UI team 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library filter dropdown now has grouped categories for:
- Programming Language
- Algorithm
- Support
