Skip to content

Add if/then/else test cases for issue #767 #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shristibot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add if/then/else test cases for issue #767 #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd13fcf
Add if/then/else test cases for issue #767
kumari-Shristi Dec 12, 2025
bc1763e
Fix description formatting in false-handling tests
kumari-Shristi Dec 12, 2025
ccfb91a
Fix description style and add false-handling tests for issue #767
kumari-Shristi Dec 12, 2025
23ff275
Fix incorrect test condition, simplify test, and copy tests to all dr…
kumari-Shristi Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 60 additions & 1 deletion tests/draft2019-09/if-then-else.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,5 +264,64 @@
"valid": false
}
]
}
},
{
"description": "then: false fails when condition matches",
"schema": {
"if": { "const": 1 },
"then": false
},
"tests": [
{
"description": "matches if → then=false → invalid",
"data": 1,
"valid": false
},
{
"description": "does not match if → then ignored → valid",
"data": 2,
"valid": true
}
]
},
{
"description": "else: false fails when condition does not match",
"schema": {
"if": { "const": 1 },
"else": false
},
"tests": [
{
"description": "matches if → else ignored → valid",
"data": 1,
"valid": true
},
{
"description": "does not match if → else executes → invalid",
"data": 2,
"valid": false
}
]
},
{
"description": "then and else both are false",
"schema":{
"if":{"type":"number"},
"then":false,
"else":false
},
"tests":[
{
"description": "matches if → then executes and else does not execute → invalid",
"data": 4,
"valid": false
},
{
"description": "does not match if → else executes → invalid",
"data": "foo",
"valid": false
}
]
}
]

60 changes: 59 additions & 1 deletion tests/draft2020-12/if-then-else.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,5 +264,63 @@
"valid": false
}
]
}
},
{
"description": "then: false fails when condition matches",
"schema": {
"if": { "const": 1 },
"then": false
},
"tests": [
{
"description": "matches if → then=false → invalid",
"data": 1,
"valid": false
},
{
"description": "does not match if → then ignored → valid",
"data": 2,
"valid": true
}
]
},
{
"description": "else: false fails when condition does not match",
"schema": {
"if": { "const": 1 },
"else": false
},
"tests": [
{
"description": "matches if → else ignored → valid",
"data": 1,
"valid": true
},
{
"description": "does not match if → else executes → invalid",
"data": 2,
"valid": false
}
]
},
{
"description": "then and else both are false",
"schema":{
"if":{"type":"number"},
"then":false,
"else":false
},
"tests":[
{
"description": "matches if → then executes and else does not execute → invalid",
"data": 4,
"valid": false
},
{
"description": "does not match if → else executes → invalid",
"data": "foo",
"valid": false
}
]
}
]
60 changes: 59 additions & 1 deletion tests/draft7/if-then-else.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,5 +254,63 @@
"valid": false
}
]
}
},
{
"description": "then: false fails when condition matches",
"schema": {
"if": { "const": 1 },
"then": false
},
"tests": [
{
"description": "matches if → then=false → invalid",
"data": 1,
"valid": false
},
{
"description": "does not match if → then ignored → valid",
"data": 2,
"valid": true
}
]
},
{
"description": "else: false fails when condition does not match",
"schema": {
"if": { "const": 1 },
"else": false
},
"tests": [
{
"description": "matches if → else ignored → valid",
"data": 1,
"valid": true
},
{
"description": "does not match if → else executes → invalid",
"data": 2,
"valid": false
}
]
},
{
"description": "then and else both are false",
"schema":{
"if":{"type":"number"},
"then":false,
"else":false
},
"tests":[
{
"description": "matches if → then executes and else does not execute → invalid",
"data": 4,
"valid": false
},
{
"description": "does not match if → else executes → invalid",
"data": "foo",
"valid": false
}
]
}
]
Loading