This repository was archived by the owner on Dec 15, 2025. It is now read-only.
Prevent panic on self-referencing structs/map/slices during Marshal#705
Open
tsuperis3112 wants to merge 1 commit intojson-iterator:masterfrom
Open
Prevent panic on self-referencing structs/map/slices during Marshal#705tsuperis3112 wants to merge 1 commit intojson-iterator:masterfrom
tsuperis3112 wants to merge 1 commit intojson-iterator:masterfrom
Conversation
tsuperis3112
force-pushed
the
recursiveptr
branch
from
8490b22 to
6f40716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
Marshalwhere it would panic when attempting to serialize self-referencing structs or slices.Previously, encountering these data structures would cause a panic, making it difficult to handle these situations gracefully. This change modifies
Marshalto return an error instead, providing a more consistent and predictable way to handle serialization errors. This aligns the behavior withjson.Marshal, which also returns an error when encountering self-referencing data structures.This improvement enhances the robustness of the library and makes it easier to handle potential errors during serialization.