fix: Add OpenGraphScraperOptions.jsonLDOptions.throwOnJSONParseError and change default behavior to not throw on JSON-LD string parse errors
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change default behavior to not throw on JSON-LD string parse errors
nickmorri
force-pushed
the
nickmorri/handle-invalid-json-parsing
branch
from
52ff9e1 to
f7bc443
Compare
Owner
|
Can you fix the eslint errors and add |
Contributor
Author
|
@jshemas done! |
Owner
|
Thank you for the pull request. |
Owner
|
Changes are live in |
Contributor
Author
|
Thanks for the speedy review and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Catch
JSON.parseerror to allow other valid JSON-LD and Open Graph data on the page to be parsed.Reproduction Steps
Retrieve https://aersf.com/products/pro-kit.
Changes
JSONLDOptionstoOpenGraphScraperOptionsJSON.parseerrors are encounteredCloses #257