Skip to content

Do not require chunked anymore#411

Closed
jlahtinen wants to merge 1 commit intojruby:masterfrom
jlahtinen:patch-1
Closed

Do not require chunked anymore#411
jlahtinen wants to merge 1 commit intojruby:masterfrom
jlahtinen:patch-1

Conversation

@jlahtinen
Copy link
Contributor

Targeting rails 8

Rack 3 does not have chunked anymore

Targeting rails 8

Rack 3 does not have chunked anymore
@chadlwilson
Copy link
Contributor

chadlwilson commented Mar 13, 2026

Thanks for taking a look, but there is much more needed to target rack 3 compatibility than this basic change and this would break 2.x support. Please collaborate on the WIP at #325 (or even better, try testing it in your env if possible)

Among other things, the parameter and session handling needs to (broadly) conform to the spec and there are some open questions to address. The PR is close, but needs some more thought.

@jlahtinen
Copy link
Contributor Author

Thanks. I will test #325

I think I was lucky with my app as it does not have any sessions. I will test #325 with apps that uses sessions...

@chadlwilson
Copy link
Contributor

chadlwilson commented Mar 16, 2026

#325 is pretty close I think. Just needs a bit more due diligence and thought (the task list is broadly up-to-date). I havent been very motivated for the last few months, but I'm getting there 😅

If I can merge it with confidence that I haven't broke anything for Rack 2.2, it's broadly on the right track (won't need major breaking changes for rack 3 which I have missed) that would also be fine, even if it's not perfect

@chadlwilson
Copy link
Contributor

My personal blind spot is that I use Rack entirely via Rails but am neither a rails nor rack expert 😅

The more sophisticated jruby-rack regression tests are also via Rails. But there are many other uses, and Rails has a particularly opinionated use of Rack, as I understand it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants