Ability to release gems for one database type at a time #1200
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits the rake command performed to only work for one of the database types listed in the DB env var
A unset DBS will still default to all, but not a blank string
removes unnecessary check for a blank string DBS env var in release:do. That will now be caught as an error elsewhere
Member
|
@mohamedhafez Thanks for this PR. When we get first adapter working for 8+ we can get those out quicker with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
DBSenv var, that will let you choose which subset of MySQL, Postgres, or SQLite you are trying to build and release gems for. Not setting it defaults to all of them, with the exception ofrelease:do: for that, just to be extra safe that what is being done is intentional, I've required the caller to explicitly set it.