test: removed expectations that SQLite3 understands timezones #1183
+14
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out SQLite3 is a flat-earther, it stores time, but doesn't believe in timezones.
Contributor
Author
|
@enebo 🎉 , all ARJDBC are green. |
Member
|
@seuros I am fine skipping these for now. I know we do have 2 open Time issues on JRuby 10 issue tracker so not sure if that could be related here or not. This local test suite are ancient subset of AR tests that occasionally get updated as Rails changes behavior. So it is possible these tests as written are no longer valid. |
Contributor
Author
|
the Timezone feature was introduced in 7.x, before that, it was just using the app timezone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could revisit this after the build is green.