remove invalid monkey patch require #1179
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java version numbers are like hieroglyphics, symbolic, nonlinear, and occasionally cursed.
Member
|
@seuros For JRuby 10 minimum is Java 21 now so it may work with 11 but there is no reason for 11 (and if we up to 21 we can use newer Java language features in the codebase) |
Contributor
Author
|
I will update it, java versioning is confusing. |
…om 8- > 11 -> 17 -> 21.:wq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@enebo , switched to java 11 target .
Now we have lot of test to fix. I'm on it.