Skip to content

Add MANIFEST.in#39

Open
jayvdb wants to merge 1 commit into
jrabbit:masterfrom
jayvdb:sdist
Open

Add MANIFEST.in#39
jayvdb wants to merge 1 commit into
jrabbit:masterfrom
jayvdb:sdist

Conversation

@jayvdb

@jayvdb jayvdb commented Oct 19, 2019

Copy link
Copy Markdown

No description provided.

@jrabbit

jrabbit commented Oct 22, 2019

Copy link
Copy Markdown
Owner

the cert fixtures don't need to be distributed imo (they need to be regenerated actually) docs is fine I guess to distribute. the project will be moving to poetry when i have the brain cycles for it idk if that impacts your motivations for this pr?

@jayvdb

jayvdb commented Oct 22, 2019

Copy link
Copy Markdown
Author

IIRC, the cert fixtures are needed to run the tests.

I'm packaging it at https://build.opensuse.org/package/show/home:jayvdb:py-taskwarrior/python-taskc

No worries wrt poetry / it would require some changes to MANIFEST.in , whenever that happens.

@jrabbit

jrabbit commented Oct 22, 2019

Copy link
Copy Markdown
Owner

Ah yeah, you do need them for the tests. That makes sense then!

@jrabbit

jrabbit commented Oct 22, 2019

Copy link
Copy Markdown
Owner

I took a peek at your buildlogs there you'll want docker.py for the tests (unused in the library code)

@jayvdb

jayvdb commented Oct 22, 2019

Copy link
Copy Markdown
Author

I suspect something broke in recent docker

ImportError: cannot import name 'Client' from 'docker' (/usr/lib/python3.7/site-packages/docker/init.py)

@jrabbit

jrabbit commented Oct 28, 2019

Copy link
Copy Markdown
Owner

Can you check if this is still needed? (I'm not sure if poetry includes everything you'd need by default)
the tests should be fixed now :)

@jrabbit jrabbit mentioned this pull request May 7, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants