Skip to content

Conversation

@UzeyirMammadov
Copy link
Contributor

@UzeyirMammadov UzeyirMammadov commented Aug 10, 2023

closes #72

@UzeyirMammadov UzeyirMammadov linked an issue Aug 10, 2023 that may be closed by this pull request
2 tasks
@CodeOfRob
Copy link
Contributor

CodeOfRob commented Aug 11, 2023

field tested populated tested empty
schemas
responses
parameters
examples
requestBodies
headers
securitySchemes
links
callbacks
pathItems

we need tests for the cases with red cross (except pathItems cause parsing of those is not implemented yet I think).
I understand, that implementing those test is not quite in scope of this migration ticket, but it would fit nicely as you already touch the needed files.
Do you want to implement them in this ticket or create a dedicated one?

Copy link
Contributor

@CodeOfRob CodeOfRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last build of this branch by Jenkins led to 5 component tests failing additionally. could you maybe look into those again?

@UzeyirMammadov
Copy link
Contributor Author

field tested populated tested empty
schemas ✅ ✅
responses ✅ ❌
parameters ✅ ❌
examples ✅ ❌
requestBodies ✅ ✅
headers ✅ ✅
securitySchemes ✅ ❌
links ✅ ✅
callbacks ✅ ✅
pathItems ❌ ❌
we need tests for the cases with red cross (except pathItems cause parsing of those is not implemented yet I think). I understand, that implementing those test is not quite in scope of this migration ticket, but it would fit nicely as you already touch the needed files. Do you want to implement them in this ticket or create a dedicated one?

I think it will be better to do it in different ticket.

Copy link
Contributor

@CodeOfRob CodeOfRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins build failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate componentsCountTest into componentsTest

3 participants