Base refactor #13
Merged
Base refactor #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 33 +1
Lines 1665 1692 +27
Branches 129 130 +1
=========================================
+ Hits 1665 1692 +27
|
Extract curl command generation functionality from BaseResource to a dedicated mixin in utils/curl_debug_mixin.py. This improves code organization by: 1. Moving a single-purpose feature into its own module 2. Simplifying the BaseResource class 3. Making the debug functionality more reusable Also updated tests to maintain 100% coverage. Improve type safety with specialized dictionary types Replace generic Optional[Dict[str, Any]] with specialized type aliases throughout the codebase: 1. ParamDict for query string parameters 2. FormDataDict for form data parameters 3. JSONDict for JSON data structures These changes provide better static type checking, improve code readability and maintainability, and fix all mypy type errors related to dictionary types. Add test for curl debug mixin without OAuth Added test case for the fallback path in CurlDebugMixin when OAuth token is not available, ensuring 100% test coverage for the mixin class. Standardize _make_request call formatting - Make endpoint the only positional argument - Use keyword arguments for all other parameters - Adopt consistent multi-line formatting - Maintain 100% test coverage This change improves code readability and maintainability by ensuring a consistent approach to API calls throughout the codebase. Add *,cover files to .gitignore These files are coverage artifacts that should not be tracked in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.