Conversation
…Reader`) currently rely on legacy defaults and need to be modernized to fully leverage Java 21 standards. These classes are essential for zero-dependency PEM parsing and SSL configuration across supported servers, but they currently default to the outdated `JKS` keystore format, prioritize older TLS versions, and utilize legacy cipher suites. * **Prioritize TLS 1.3:** Update the protocol fallback logic in `JdkSslContext` to prioritize `TLSv1.3` and drop deprecated protocols. * **Modernize Ciphers:** Remove outdated ciphers (e.g., 3DES) and ensure high-security TLS 1.3 ciphers are at the top of the preference list. * **Update Keystore Format:** Replace hardcoded `"JKS"` instances with `KeyStore.getDefaultType()` to utilize the modern PKCS12 standard. * **Optimize PEM Parsing:** Refactor `PemReader` to use `Base64.getMimeDecoder()` for native, efficient handling of line breaks, replacing the manual regex string manipulation. * **Syntax Cleanup:** Apply the diamond operator (`<>`) across all files to clean up legacy generics. fix #3877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Reader`) currently rely on legacy defaults and need to be modernized to fully leverage Java 21 standards.
These classes are essential for zero-dependency PEM parsing and SSL configuration across supported servers, but they currently default to the outdated
JKSkeystore format, prioritize older TLS versions, and utilize legacy cipher suites.JdkSslContextto prioritizeTLSv1.3and drop deprecated protocols."JKS"instances withKeyStore.getDefaultType()to utilize the modern PKCS12 standard.PemReaderto useBase64.getMimeDecoder()for native, efficient handling of line breaks, replacing the manual regex string manipulation.<>) across all files to clean up legacy generics.fix #3877