fix(ui): add missing ui.tool.skill i18n key; guard TextShimmer against undefined text#1
Draft
fix(ui): add missing ui.tool.skill i18n key; guard TextShimmer against undefined text#1
ui.tool.skill i18n key; guard TextShimmer against undefined text#1Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… undefined text Co-authored-by: jon23d <1146473+jon23d@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix universal session error in opencode web
Fix web session crash: add missing Mar 7, 2026
ui.tool.skill i18n key and harden TextShimmer
Copilot
AI
changed the title
Fix web session crash: add missing
fix(ui): add missing Mar 7, 2026
ui.tool.skill i18n key and harden TextShimmerui.tool.skill i18n key; guard TextShimmer against undefined text
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "STUPID SEXY TIMELINE" refactor (
bbd0f3a25, Mar 7) changed theskilltool renderer from a hardcodedinput.name || "skill"fallback toi18n.t("ui.tool.skill"), but never added the key to any locale dictionary.@solid-primitives/i18nreturnsundefinedfor missing keys; thatundefinedreachedTextShimmer, which callsprops.text.lengthin a reactive style computation — instant crash for every session that ran a skill tool call.Type of change
What does this PR do?
packages/ui/src/i18n/en.ts+ all 16 locale files — adds"ui.tool.skill"with appropriate translations (e.g."Skill","技能","Compétence", etc.)packages/ui/src/components/text-shimmer.tsx— guardsprops.textwith?? ""in bothshimmerSizeandshimmerDurationmemos so any future missing i18n key degrades gracefully instead of crashingHow did you verify your code works?
Traced the call path:
bbd0f3a25introducedi18n.t("ui.tool.skill")in the skillToolRegistryrenderer without defining the key →translator()returnsundefined→ passed astexttoTextShimmer→props.text.lengththrows. Confirmed the key was absent fromen.ts(and all locales) prior to this fix.Screenshots / recordings
UI-only crash fix; no visual change.
Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.