Merged
Conversation
- add @testing-library/react-native and eslint-plugin-testing-library as dev dependencies - configure eslint to use testing-library plugin for test files - update react-native-builder-bob to latest version - add react-test-renderer as dev dependency
- add test case to ensure caret is not rendered when caretHidden is true - add testID to Caret component for easier testing
…g tests - refactor render function to destructure props with default maxLength - add test to verify slots rendered match maxLength prop - add testID to TextInputOTPSlot component for easier testing - improve existing test descriptions for clarity
removed unnecessary async keyword from the test case that checks if the component renders slots up to the maxLength prop
…g tests - add test case for setValue method - update renderTextInputOTP function - import act and createRef - add onFilled callback in setValue method
- add test case to verify that the clear function clears input text when called programmatically - ensure that the cleared text is not visible in the component after calling clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add unit tests to core functionalities