Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
johannesjo
reviewed
Mar 19, 2026
Owner
There was a problem hiding this comment.
Thank you very much for this and sorry for the late reply. Somehow I wasn't receiving notifications for PRs opened here.
Icon padding affects Linux
The updated PNGs (icon.png, 128x128.png, 128x128@2x.png) have inner transparent padding to fix macOS Dock sizing — but these same files are used by Linux (taskbar, tray, BrowserWindow). macOS never actually reads the PNGs:
- macOS build: electron-builder uses
icon.icns(already present inbuild/) - macOS runtime:
getIconPath()inelectron/main.ts:69returnsundefinedon non-Linux - Linux build + runtime: uses
icon.pngand the128x128variants exclusively
Suggested fix: Revert the 3 PNG files to their originals (no padding) and keep only the icon.icns change. This fixes macOS without shrinking Linux icons. No config or code changes needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
128x128.png,128x128@2x.png,icon.icns,icon.png) to correct sizes for proper display in Dock, Finder, and app switcherUpdated icon size
Test plan
npm run build) and verify the icon renders at correct size in the Dock