Refine UIAppearance behavior #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of cell sizes.
…ly. Much discussion was had over this code at WWDC17.
BENMESSAOUD
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to use UIAppearance properties with PDTSimpleCalendar, I saw odd behavior and dug in further. In an unsurprising case, Apple's documentation on how to create a UIAppearanceContainer is skimpy and sometimes wrong. After digging into the code and discussing it with engineers in the WWDC17 labs, I have made these changes. The engineers involved have requested that I file a documentation bug with Apple. Which I am doing.
Primarily, I have moved the default properties into
+initializeand then used them in the-didMoveToWindow. Almost all custom accessors have been removed. This allows a cleaner execution model and is the WWDC17 labs consensus preferred implementation.The code is now shorter, aligns with the UIAppearanceContainer pattern, and works.