add nix package manager support#3471
Open
reshmifrog wants to merge 5 commits into
Open
Conversation
reshmifrog
added
the
safe to test
reshmifrog
added
safe to test
reshmifrog
force-pushed
the
RTECO-1040-Nix-package-support
branch
from
2ee1770 to
012badb
Compare
reshmifrog
added
safe to test
reshmifrog
added
safe to test
reshmifrog
added
safe to test
Balasubramanyamkosuri
approved these changes
May 19, 2026
Balasubramanyamkosuri
left a comment
Balasubramanyamkosuri
left a comment
There was a problem hiding this comment.
Review summary
Nice integration — help examples, NixCmd parsing, and the IT suite with channel/flake fixtures are thorough.
Suggestions (non-blocking)
- Add
jf nixto build-tools overview / command reference when ready for GA. - Consider
Hidden: trueuntil GA (consistent withjf uvpre-release). - Pin released versions of build-info-go and jfrog-cli-artifactory after upstream PRs merge.
- Clarify in help:
jf nix build(flake) vsjf nix nix-build.
Merge order: build-info-go#378 → cli-artifactory#442 → this PR.
Structured review: docs/reviews/nix-pr-review.md in team workspace.
naveenku-jfrog
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Added nix package manager support