Skip to content

Removing 'source results only' possibility from PR scan #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eranturgeman merged 2 commits into from
Jan 4, 2026
Merged

Removing 'source results only' possibility from PR scan #1015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb3d3c3
removing olf logic of only source results in PR scan
eranturgeman Dec 29, 2025
b7b6f9c
remove redundant defensive check
eranturgeman Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions scanpullrequest/scanpullrequest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,10 @@ func auditPullRequestSourceCode(repoConfig *utils.Repository, scanDetails *utils
}
// Set JAS output flags based on the scan results
repoConfig.OutputWriter.SetJasOutputFlags(scanResults.EntitledForJas, scanResults.HasJasScansResults(jasutils.Applicability))
workingDirs := []string{strings.TrimPrefix(sourceBranchWd, string(filepath.Separator))}
if targetBranchWd != "" && scanDetails.ResultsToCompare != nil {
log.Debug("Diff scan - converting to new issues...")
workingDirs = append(workingDirs, strings.TrimPrefix(targetBranchWd, string(filepath.Separator)))
}

filterFailedResultsIfScannersFailuresAreAllowed(scanDetails.ResultsToCompare, scanResults, repoConfig.Params.ConfigProfile.GeneralConfig.FailUponAnyScannerError, sourceBranchWd, targetBranchWd)

issuesCollection, e := scanResultsToIssuesCollection(scanResults, workingDirs...)
log.Debug("Diff scan - converting to new issues...")
issuesCollection, e := scanResultsToIssuesCollection(scanResults, strings.TrimPrefix(sourceBranchWd, string(filepath.Separator)), strings.TrimPrefix(targetBranchWd, string(filepath.Separator)))
if e != nil {
err = errors.Join(err, fmt.Errorf("failed to get issues for pull request. Error: %s", e.Error()))
}
Expand Down
Loading