Change 'Keep file' shortcut from 'k' to 'r' in merge conflict menu#5366
Open
tusharmurali wants to merge 1 commit intojesseduffield:masterfrom
Open
Change 'Keep file' shortcut from 'k' to 'r' in merge conflict menu#5366tusharmurali wants to merge 1 commit intojesseduffield:masterfrom
tusharmurali wants to merge 1 commit intojesseduffield:masterfrom
Conversation
'k' conflicts with vim-style navigation for moving up in the menu. Changed to 'r' (retain) to avoid accidental selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving non-textual merge conflicts (e.g. file modified on one side, deleted on the other), the "Keep file" option has shortcut key 'k'. This conflicts with vim-style navigation where 'k' moves up in the menu, leading to accidental selection when users just want to navigate.