fix: use selected remote when opening commit in browser#5348
Open
Xavrir wants to merge 3 commits intojesseduffield:masterfrom
Open
fix: use selected remote when opening commit in browser#5348Xavrir wants to merge 3 commits intojesseduffield:masterfrom
Xavrir wants to merge 3 commits intojesseduffield:masterfrom
Conversation
Xavrir
force-pushed
the
fix/open-commit-in-browser-uses-selected-remote
branch
from
84fcb81 to
524bbff
Compare
Xavrir
force-pushed
the
fix/open-commit-in-browser-uses-selected-remote
branch
from
4b85114 to
003af24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When browsing commits under a specific remote (Remotes > second remote > branch > commit), pressing
oto open in browser or copying the commit URL always used theoriginremote's URL. This meant it opened the wrong page if the commit came from a different remote.The
HostHelper.getHostingServiceMgr()had"origin"hardcoded. Now there's aGetCommitURLForRemotevariant that takes a remote name, andBasicCommitsControllerextracts the remote name from theSubCommitsContextref when it's aRemoteBranch. Falls back tooriginfor local commits and reflog.Fixes #5260
CONTRIBUTING.md.