fix ctrl-i/ctrl-h/ctrl-b/ctrl-f#5149
Draft
phanen wants to merge 2 commits intojesseduffield:masterfrom
Draft
Conversation
tcell now can distinguish them phanen/tcell@74fd487 I always use c-i as tab key, to resume the behavior, this commit allow: togglePanel: <c-i>
stefanhaller
reviewed
Jan 3, 2026
Comment on lines
+55
to
+60
| gocui.KeyCtrlH: "<c-h>", | ||
| gocui.KeyCtrlI: "<c-i>", | ||
| gocui.KeyCtrlJ: "<c-j>", | ||
| gocui.KeyCtrlK: "<c-k>", | ||
| gocui.KeyCtrlL: "<c-l>", | ||
| gocui.KeyCtrlM: "<c-m>", |
Collaborator
There was a problem hiding this comment.
I don't want to add any of these to the list just yet. The upgrade of tcell allows us to have many more available keybindings (e.g. <s-c-a-pgup>), but we need some changes to our keybinding infrastructure to handle these. And they will only be available if the terminal supports the new key event protocol, so we need to find a way to warn the user if theirs doesn't. I'm working on this (slowly, might take a few more weeks), and I want to add these missing keybindings then.
Contributor
Author
There was a problem hiding this comment.
Thanks. Now for me the only missing part is to make can work as tab in lazygit (togglePanel). Which I think you will resolve later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
After updating from source I notice many keybind broken.
Because a recent bump of gocui/tcell.
gocui pr: jesseduffield/gocui#92
Please check if the PR fulfills these requirements
go generate ./...)