Security: Prototype pollution risk in recursive object merge#311
Open
tuanaiseo wants to merge 1 commit intojeremydaly:mainfrom
Open
Conversation
`deepMerge` only blocks the `__proto__` key, but still recursively merges attacker-controlled nested objects and uses `Object.assign(a, b)` on non-object branches. This can allow pollution through `constructor.prototype`-style payloads or unsafe key propagation when untrusted input reaches merge paths. Affected files: utils.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
deepMergeonly blocks the__proto__key, but still recursively merges attacker-controlled nested objects and usesObject.assign(a, b)on non-object branches. This can allow pollution throughconstructor.prototype-style payloads or unsafe key propagation when untrusted input reaches merge paths.Severity:
highFile:
lib/utils.jsSolution
Harden merge logic by explicitly rejecting
__proto__,prototype, andconstructorat every depth; avoidObject.assign(a, b)with untrusted objects; and consider replacing with a vetted safe-merge utility that prevents prototype mutation.Changes
lib/utils.js(modified)Testing