Add subgroup event support and update pom.xml #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Member
|
Hi @n0kke may I ask what is this PR intended for? |
Author
The purpose of this PR is to add support for GitLab subgroup webhook events, which are not currently handled by the plugin (along with other event types). This change enables Jenkins jobs to respond correctly to events originating from GitLab subgroups, aligning their behaviour with that of group and project events. The update to the pom.xml was necessary solely to resolve build and dependency compatibility issues encountered during the implementation and testing of this change, and does not affect the plugin's runtime behaviour. |
krisstern
requested changes
Dec 29, 2025
|
|
||
| <artifactId>gitlab-plugin</artifactId> | ||
| <version>${revision}${changelist}</version> | ||
| <version>1.9.10-SNAPSHOT</version> |
Member
There was a problem hiding this comment.
Suggested change
| <version>1.9.10-SNAPSHOT</version> | |
| <version>${revision}${changelist}</version> |
Please undo this change
Comment on lines
-291
to
-308
| <plugin> | ||
| <artifactId>maven-enforcer-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>display-info</id> | ||
| <configuration> | ||
| <rules> | ||
| <requireUpperBoundDeps> | ||
| <excludes combine.children="append"> | ||
| <exclude>com.sun.activation:jakarta.activation</exclude> | ||
| <exclude>jakarta.xml.bind:jakarta.xml.bind-api</exclude> | ||
| </excludes> | ||
| </requireUpperBoundDeps> | ||
| </rules> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Submitter checklist